Return archive in zip stream #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yichen88 <[email protected]>
yichen88
force-pushed
the
not_store_zip_locally
branch
from
f598c6a to
7169c9b
Compare
|
SonarCloud Quality Gate failed.
|
mathbagu
reviewed
Jun 15, 2020
Contributor
mathbagu
left a comment
mathbagu
left a comment
There was a problem hiding this comment.
From my point of view, you miss something. When I created the issue, I would to create a ZipInputStream to avoid creating a temporary folder on the server side. I don't understand how this PR how solve this issue?
Comment on lines
+82
to
+90
| try { | ||
| if (Files.isDirectory(someFileToZip)) { | ||
| addDirectory(zos, pathInZip); | ||
| } else { | ||
| addFile(zos, someFileToZip, pathInZip); | ||
| } | ||
| } catch (IOException e) { | ||
| throw new AfsStorageException(e.getMessage()); | ||
| } |
Contributor
There was a problem hiding this comment.
To make this lambda smaller, you should catch exception in addDirectory and addFile
Comment on lines
+58
to
+75
| public static ZipInputStream zip(Path dir, boolean deleteDirectory) throws IOException { | ||
| byte[] bytes; | ||
| try (ByteArrayOutputStream baos = new ByteArrayOutputStream(); | ||
| ZipOutputStream zos = new ZipOutputStream(baos); | ||
| Stream<Path> walk = Files.walk(dir)) { | ||
| zip(walk, dir, zos); | ||
| zos.close(); | ||
| baos.close(); | ||
| bytes = baos.toByteArray(); | ||
| } catch (IOException | AfsStorageException e) { | ||
| throw new IOException(e); | ||
| } | ||
|
|
||
| if (deleteDirectory) { | ||
| deleteDirectory(dir); | ||
| } | ||
| return new ZipInputStream(new ByteArrayInputStream(bytes)); | ||
| } |
Contributor
There was a problem hiding this comment.
Are you creating a pipe (i.e. creating a zip from a path, and returning a input-stream for this path)?
In that case, could you use PipedInputStream/PipedOutputStream as it's done in NetworkXml.copy?
rolnico
pushed a commit
that referenced
this pull request
Sep 2, 2025
Adding and/or expanding the json model generation of cells, blocks, nodes, edges, graph, substationgraph classes Generating and comparing json instead of svg files for some test cases Adding test for SVGWriter based on graph manually created Corrections in test case for Sonar (at least one assertion in test method) We don't rely on filesystem anymore in test cases Signed-off-by: Franck LECUYER <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the rest#31
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)